This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 833
Live location sharing - consolidate maps #8236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerryarchibald
added
the
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
label
Apr 5, 2022
kerryarchibald
force-pushed
the
psf-880/new-generic-map
branch
from
April 11, 2022 09:24
46e11ec
to
b16c43b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #8236 +/- ##
===========================================
+ Coverage 29.43% 29.51% +0.08%
===========================================
Files 867 869 +2
Lines 49953 49961 +8
Branches 12708 12708
===========================================
+ Hits 14702 14747 +45
+ Misses 35251 35214 -37
|
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
kerryarchibald
force-pushed
the
psf-880/new-generic-map
branch
from
April 11, 2022 12:10
a808d5e
to
defb8d3
Compare
t3chguy
approved these changes
Apr 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new generic
Map
component to cover all the 'read' cases for maps (Location share dialog still builds its own map for now)(No visual change from current)
Normal layout:
Dialog view
Bubble layout:
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr8236--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.