Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Live location sharing - consolidate maps #8236

Merged
merged 15 commits into from
Apr 11, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Apr 5, 2022

Creates a new generic Map component to cover all the 'read' cases for maps (Location share dialog still builds its own map for now)

(No visual change from current)

Normal layout:
Screenshot 2022-04-05 at 19 12 30

Dialog view
Screenshot 2022-04-05 at 19 12 08

Bubble layout:
Screenshot 2022-04-05 at 19 12 00

Screenshot 2022-04-05 at 19 10 49


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr8236--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #8236 (defb8d3) into develop (b760ec9) will increase coverage by 0.08%.
The diff coverage is 92.98%.

@@             Coverage Diff             @@
##           develop    #8236      +/-   ##
===========================================
+ Coverage    29.43%   29.51%   +0.08%     
===========================================
  Files          867      869       +2     
  Lines        49953    49961       +8     
  Branches     12708    12708              
===========================================
+ Hits         14702    14747      +45     
+ Misses       35251    35214      -37     
Impacted Files Coverage Δ
src/components/views/location/LocationPicker.tsx 91.86% <ø> (ø)
...c/components/views/location/LocationViewDialog.tsx 92.30% <83.33%> (+92.30%) ⬆️
src/utils/location/useMap.ts 84.61% <84.61%> (ø)
src/components/views/messages/MLocationBody.tsx 93.75% <90.90%> (+25.75%) ⬆️
src/components/views/location/Map.tsx 100.00% <100.00%> (ø)
src/utils/location/map.ts 69.04% <0.00%> (-16.67%) ⬇️
src/utils/WellKnownUtils.ts 61.76% <0.00%> (+17.64%) ⬆️

Kerry Archibald added 15 commits April 11, 2022 14:01
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald merged commit 9ba55d1 into develop Apr 11, 2022
@kerryarchibald kerryarchibald deleted the psf-880/new-generic-map branch April 11, 2022 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants