Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix soft crash around the thread panel in degraded mode #8261

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Apr 8, 2022

Fixes element-hq/element-web#21719


This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

Preview: https://pr8261--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@t3chguy t3chguy requested a review from a team as a code owner April 8, 2022 10:58
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #8261 (07d6a1b) into develop (f63923d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #8261      +/-   ##
===========================================
- Coverage    28.60%   28.60%   -0.01%     
===========================================
  Files          862      862              
  Lines        49788    49789       +1     
  Branches     12680    12681       +1     
===========================================
  Hits         14241    14241              
- Misses       35547    35548       +1     
Impacted Files Coverage Δ
src/components/structures/ThreadPanel.tsx 23.07% <0.00%> (-0.30%) ⬇️

Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The roomId is not unique. If you switch to "my threads" only, it'd have the same key as for all room threads

@t3chguy t3chguy requested a review from germain-gg April 8, 2022 11:26
@t3chguy t3chguy enabled auto-merge (squash) April 8, 2022 11:26
@t3chguy t3chguy merged commit 9f8c208 into develop Apr 8, 2022
@t3chguy t3chguy deleted the t3chguy/rs/11838 branch April 8, 2022 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threads soft crash when switching rooms
2 participants