Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Implement improved spacing for the thread list and timeline #8337

Merged
merged 41 commits into from
Apr 29, 2022
Merged

Implement improved spacing for the thread list and timeline #8337

merged 41 commits into from
Apr 29, 2022

Commits on Apr 15, 2022

  1. Fix avatar size: Thread list and thread timeline 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    b7f9296 View commit details
    Browse the repository at this point in the history

  2. Thread list: Right padding 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    54f4dfc View commit details
    Browse the repository at this point in the history

  3. Thread list: Padding inside each thread 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    05cad5e View commit details
    Browse the repository at this point in the history

  4. Thread list: Margin between thread and border 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    24d65ab View commit details
    Browse the repository at this point in the history

  5. Thread list: Align the reply summary, avatar, and the content 

    .mx_ThreadInfo has already adopted flexbox to align elements

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    5bcde0c View commit details
    Browse the repository at this point in the history

  6. Thread list: Spacing with the scroll bar enabled / disabled 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    48e4db9 View commit details
    Browse the repository at this point in the history

  7. Thread list: Remove the magic number from the timestamp 

    The magic number has been used for spacing, and it is no longer
required.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    31711f1 View commit details
    Browse the repository at this point in the history

  8. Thread list: Remove !important to clarify the rule dependency 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    7d3ac60 View commit details
    Browse the repository at this point in the history

  9. Thread list: Spacing horizontal bar and right border 

    - Spacing between the left border and horizontal bar
- Spacing between the right border and thread list

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    0ed326f View commit details
    Browse the repository at this point in the history

  10. Thread list: MessageActionBar 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    8655734 View commit details
    Browse the repository at this point in the history

  11. Thread list: Dedupe (profile and eventtile line padding) 

    !important does not seem to be required.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    fa25451 View commit details
    Browse the repository at this point in the history

  12. Thread list: Background-color 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    a93a5a8 View commit details
    Browse the repository at this point in the history

  13. Normalize: Thread info icon 

    Share the style rules to display the thread info icons on the main panel
and the right panel.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    c4b7a3b View commit details
    Browse the repository at this point in the history

  14. Thread Timeline: Right margin 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    fb8cd59 View commit details
    Browse the repository at this point in the history

  15. Thread list: Right margin 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    317654f View commit details
    Browse the repository at this point in the history

  16. Thread Timeline: Avatar left padding 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    2a366bf View commit details
    Browse the repository at this point in the history

  17. Thread Timeline: Message left margin 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    8ee9e71 View commit details
    Browse the repository at this point in the history

  18. Thread Timeline: Action bar position 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    25b854f View commit details
    Browse the repository at this point in the history

  19. Thread Timeline: Message action bar position and padding inside a mes… 

    …sage

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    bba2bde View commit details
    Browse the repository at this point in the history

  20. Thread Timeline: Spacing between the avatar and the right border (bub… 

    …ble message layout)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    e7988ec View commit details
    Browse the repository at this point in the history

  21. Add comments 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    ba6d4a9 View commit details
    Browse the repository at this point in the history

  22. Thread Timeline: Fix sender ID, avatar, and spacing 

    - Display sender ID
- Set gap between the avatar and the ID

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    29bb381 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Merge branch 'develop' into Thread

    @luixxiul
    luixxiul authored Apr 20, 2022
    Configuration menu
    Copy the full SHA
    d80cc2e View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Set z-index to MessageActionBar with a variable 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    0661f0f View commit details
    Browse the repository at this point in the history

  2. 8px spacing with AutoHideScrollbar 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    e9ea310 View commit details
    Browse the repository at this point in the history

  3. 8px spacing below mx_EventTile_line 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    b4187e4 View commit details
    Browse the repository at this point in the history

  4. Add 2px to leftOffset 

    - Spacing between the avatar and the event tile: 48px - 32px = 16px
- Spacing between the left edge and the event tile: 48px + 8px + 8px = 64px

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    b739ebf View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Merge branch 'develop' of https://github.com/matrix-org/matrix-react-sdk 

     into Thread
    @luixxiul
    luixxiul committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    5b867c6 View commit details
    Browse the repository at this point in the history

  2. Remove ThreadPanel_ThreadInfo 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    e97d112 View commit details
    Browse the repository at this point in the history

  3. Vertical: 12px gap and 20px gap 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    3ab6c70 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Horizontal: spacing 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    a413e3a View commit details
    Browse the repository at this point in the history

  2. Vertical: spacing around 1px horizontal line 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    ef33183 View commit details
    Browse the repository at this point in the history

  3. Fix regressions: chat panel with a maximized widget 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    addd6a7 View commit details
    Browse the repository at this point in the history

  4. Set padding-top: 16px 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    afce31e View commit details
    Browse the repository at this point in the history

  5. Fix regression: timestamp position inside a thread 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    5fb4274 View commit details
    Browse the repository at this point in the history

  6. Fix position of the message action bar 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    b737bef View commit details
    Browse the repository at this point in the history

  7. Fix regression: line height of profile 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    1a5b503 View commit details
    Browse the repository at this point in the history

  8. Simplify the structure 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    e65bb2e View commit details
    Browse the repository at this point in the history

  9. Revert the one line change 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    423a235 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Update src/components/views/rooms/EventTile.tsx 

    Based on the suggestion.

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
    @luixxiul @t3chguy
    luixxiul and t3chguy authored Apr 29, 2022
    Configuration menu
    Copy the full SHA
    7c06cbe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of https://github.com/matrix-org/matrix-react-sdk 

     into Thread
    @luixxiul
    luixxiul committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    508dbb2 View commit details
    Browse the repository at this point in the history