Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Patch: "Reloading the registration page should warn about data loss" #8377

Merged
merged 15 commits into from
Apr 29, 2022
Merged

Patch: "Reloading the registration page should warn about data loss" #8377

Changes from 9 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ac39d61
warn of data loss on reloading registration page
yaya-usman Apr 20, 2022
3c47141
update: warn on loss of data on refresh
yaya-usman Apr 20, 2022
e37af06
Merge branch 'develop' of https://github.com/yaya-usman/matrix-react-…
yaya-usman Apr 20, 2022
2c9712b
update: unloadCallback made private
yaya-usman Apr 20, 2022
b29c417
proper event annotation
yaya-usman Apr 21, 2022
872d0e0
resolve conflict
yaya-usman Apr 21, 2022
9fe77a8
update: popup the dialog warning at a later stage of registration
yaya-usman Apr 21, 2022
8b0dca2
updated branch
yaya-usman Apr 24, 2022
9b92c90
show warn dialog only at a later stage of registration
yaya-usman Apr 24, 2022
48636c6
Merge branch 'develop' of https://github.com/yaya-usman/matrix-react-…
yaya-usman Apr 25, 2022
584d54e
updated fix
yaya-usman Apr 25, 2022
8ed065f
resolve conflict
yaya-usman Apr 27, 2022
75c3627
updated warn dialog logic
yaya-usman Apr 27, 2022
71e9932
Merge branch 'develop' of https://github.com/yaya-usman/matrix-react-…
yaya-usman Apr 29, 2022
736eae1
updated fix
yaya-usman Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/components/structures/auth/Registration.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,22 @@ export default class Registration extends React.Component<IProps, IState> {
this.replaceClient(this.props.serverConfig);
}

componentDidUpdate() {
if (this.state.doingUIAuth) {
//triggers a confirmation dialog for data loss before page unloads/refreshes
window.addEventListener("beforeunload", this.unloadCallback);
}
}
t3chguy marked this conversation as resolved.
Show resolved Hide resolved

componentWillUnmount() {
window.removeEventListener("beforeunload", this.unloadCallback);
}

private unloadCallback = (event: BeforeUnloadEvent) => {
event.preventDefault();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will always show the confirmation dialog

According to the specification, to show the confirmation dialog an event handler should call preventDefault() on the event.

(Empirically only in Firefox & Safari)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's now working as it should. I have tested it in the three browsers.

event.returnValue = "";
return "";
};
// TODO: [REACT-WARNING] Replace with appropriate lifecycle event
// eslint-disable-next-line
UNSAFE_componentWillReceiveProps(newProps) {
Expand Down