This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Initial implementation: SetDisplayName -> SetMxIdDialog #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaces SetDisplayNameDialog with SetMxIdDialog. This new dialog will use InteractiveAuth to authenticate a user with their chosen mxid. De-scoped: - style tweaks for the InteractiveAuth in the dialog (capcha) and error message. - checking for mxid availability
dbkr
reviewed
Apr 28, 2017
| @@ -0,0 +1,153 @@ | |||
| /* | |||
| Copyright 2016 OpenMarket Ltd | |||
| }, | ||
|
|
||
| _generateAndCachePassword: function() { | ||
| const pass = Math.random().toString(36).slice(2); |
|
|
||
| return this._matrixClient.register( | ||
| this.state.username, | ||
| this._generateAndCachePassword(), |
There was a problem hiding this comment.
So here you're setting the password before the account is registered (and overwriting it with a new one for each time we try to register). It feels like it really ought to be set along with the access token.
|
Oh also you seem to have met our new friend, |
added 3 commits
May 2, 2017 09:56
So that we don't overwrite the existing one every time we try to register.
|
It looks like |
dbkr
approved these changes
May 2, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
De-scoped:
For now, based on element-hq/element-web#3604 (comment)