Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove width setting for RoomView_messageListWrapper on the thread panel #8503

Closed
wants to merge 1 commit into from
Closed

Remove width setting for RoomView_messageListWrapper on the thread panel #8503

wants to merge 1 commit into from

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 5, 2022

Follow-up to #8337
Fixes element-hq/element-web#22079

This PR removes the width setting for thread panel which has set the spacing between the right border and the event tile.

after

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

type: defect


Here's what your changelog entry will look like:

🐛 Bug Fixes

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label May 5, 2022
@luixxiul luixxiul marked this pull request as ready for review May 5, 2022 06:35
@luixxiul luixxiul requested a review from a team as a code owner May 5, 2022 06:35
@luixxiul luixxiul marked this pull request as draft May 5, 2022 12:54
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty review as this is a draft, please re-request review when ready

@luixxiul
Copy link
Contributor Author

luixxiul commented May 8, 2022

I'm not really sure if this is necessary, since it might be a bug of Firefox 100, not of matrix-react-sdk, tracked here: element-hq/element-web#22084

@luixxiul luixxiul changed the title Remove width hack for RoomView_messageListWrapper on the thread panel Remove width setting for RoomView_messageListWrapper on the thread panel May 8, 2022
@MadLittleMods MadLittleMods added the Z-Community-PR Issue is solved by a community member's PR label Jun 1, 2022
@luixxiul
Copy link
Contributor Author

Closing as I am no longer sure whether this would be a right solution.

@luixxiul luixxiul closed this Apr 21, 2023
@luixxiul luixxiul deleted the RoomView_messagePanel branch April 21, 2023 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Narrow spacing between the thread panel and the event tile on Firefox 100 on Debian
3 participants