Improve handling of the disabled state of the save button in the edit message composer

[SimonBrandner]

Fixes element-hq/element-web#22207

---

Peek.2022-05-15.09-41.mp4

---

Here's what your changelog entry will look like:

✨ Features

• Improve handling of the disabled state of the save button in the edit message composer (#8601). Fixes Broken state when editing element-hq/element-web#22207.

[t3chguy]

This was done intentionally to begin with, the Save button felt weird being enabled & re-disabled, so the Save action itself actually skipped sending the event edit if there was no change in the end

[turt2live]

this is a surprising amount of code change for a relatively mundane feature - will wait for design to provide feedback before reviewing this.

[HarHarLinks]

(I raised this issue)

This was done intentionally to begin with, the Save button felt weird being enabled & re-disabled, so the Save action itself actually skipped sending the event edit if there was no change in the end

This behaviour is fine by me, I would even say it makes sense. However the part where the save action skips sending should also apply to keyboard navigation, i.e. should prohibit dismissing via up/down arrows only when the message is actually edited.

[andybalaam]

(I raised this issue)

This was done intentionally to begin with, the Save button felt weird being enabled & re-disabled, so the Save action itself actually skipped sending the event edit if there was no change in the end

This behaviour is fine by me, I would even say it makes sense. However the part where the save action skips sending should also apply to keyboard navigation, i.e. should prohibit dismissing via up/down arrows only when the message is actually edited.

See my message on the issue about why I closed it. I also want to address this comment.

I think if I am navigating with up/down and then edit a message, and then undo, I don't want up/down to move me away, for the same reasons as I gave in the issue: it adds a mental burden on me to understand the different behaviour, just because my edits ended up having no effect.

[andybalaam]

Closing this PR since I close the related issue.

Thank you for your work on this!