This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Abstract electron settings properly to avoid boilerplate-hell #8798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
the
T-Task
turt2live
approved these changes
Jun 10, 2022
t3chguy
added a commit
that referenced
this pull request
Jun 14, 2022
* Remove unused method `BasePlatform::screenCaptureErrorString` * Improve platform typescripting * Remove redundant awaits * Abstract electron settings properly to avoid boilerplate-hell * i18n * Fix stray semi-colons * Fix setting level order for Platform settings (cherry picked from commit ba2ce5e)
su-ex
added a commit
to SchildiChat/element-desktop
that referenced
this pull request
Jun 16, 2022
* Fix missing element desktop preferences ([\#8798](matrix-org/matrix-react-sdk#8798)). Contributed by @t3chguy.
su-ex
added a commit
to SchildiChat/element-web
that referenced
this pull request
Jun 16, 2022
* Fix missing element desktop preferences ([\element-hq#8798](matrix-org/matrix-react-sdk#8798)). Contributed by @t3chguy.
su-ex
added a commit
to SchildiChat/matrix-react-sdk
that referenced
this pull request
Jun 16, 2022
* Fix CallView crash ([\matrix-org#8735](matrix-org#8735)). Contributed by @SimonBrandner. * Fix missing element desktop preferences ([\matrix-org#8798](matrix-org#8798)). Contributed by @t3chguy.
coolmic
added a commit
to livegen/riot-web
that referenced
this pull request
Jun 26, 2022
* Fix missing element desktop preferences ([\element-hq#8798](matrix-org/matrix-react-sdk#8798)). Contributed by @t3chguy.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires element-hq/element-web#22491
I suggest reviewing commit-by-commit
This change is marked as an internal change (Task), so will not be included in the changelog.