Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Set common width, white-space, and display values to MessageTimestamp #8818

Merged
merged 12 commits into from
Jun 30, 2022
Merged

Set common width, white-space, and display values to MessageTimestamp #8818

merged 12 commits into from
Jun 30, 2022

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jun 12, 2022

This PR sets common width, white-space, and display value to mx_MessageTimestamp, adding the class name to mx_PinnedEventTile_timestamp.

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com


This change is marked as an internal change (Task), so will not be included in the changelog.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
- Unset display and width value of timestamp on pinned messages card

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…ize setting

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
- GroupLayout is modern layout, not IRC layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Jun 12, 2022
@@ -109,7 +109,6 @@ limitations under the License.
position: initial;
font-size: $font-14px;
opacity: 1.0;
color: $event-timestamp-color;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -196,7 +195,6 @@ limitations under the License.
}

.mx_MessageTimestamp {
font-size: $font-12px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max-width: 80px;
width: auto;
font-size: $font-12px;
max-width: var(--MessageTimestamp-max-width);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$MessageTimestamp_width is enabled here.

Before After
before after

.mx_MessageTimestamp {
font-size: $font-10px;
}

Copy link
Contributor Author

@luixxiul luixxiul Jun 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
before1 after1

@@ -1027,6 +1020,7 @@ $threadInfoLineHeight: calc(2 * $font-12px); // See: _commons.scss

.mx_MessageTimestamp {
top: 2px; // Align with mx_EventTile_content
position: absolute; // for IRC layout
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
before after

color: $secondary-content;
display: unset;
width: unset; // Cancel the default width value
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
before after

color: $event-timestamp-color;
font-size: $font-10px;
font-variant-numeric: tabular-nums;
display: block; // enable the width setting below
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because width declaration below is supposed to be enabled by default.

@luixxiul luixxiul marked this pull request as ready for review June 12, 2022 05:00
@luixxiul luixxiul requested a review from a team as a code owner June 12, 2022 05:00
.mx_MessageTimestamp {
width: unset; // Cancel the default width
max-width: var(--MessageTimestamp-max-width);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
before after

@@ -849,6 +849,7 @@ $threadInfoLineHeight: calc(2 * $font-12px); // See: _commons.scss
.mx_MessageTimestamp {
font-size: $font-12px;
max-width: var(--MessageTimestamp-max-width);
position: initial;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luixxiul
Copy link
Contributor Author

Fixed the conflict.

@SimonBrandner SimonBrandner merged commit 78a9841 into matrix-org:develop Jun 30, 2022
@luixxiul luixxiul deleted the MessageTimestamp branch June 30, 2022 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants