-
-
Notifications
You must be signed in to change notification settings - Fork 833
Set common width, white-space, and display values to MessageTimestamp #8818
Conversation
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
- Unset display and width value of timestamp on pinned messages card Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…ize setting Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
- GroupLayout is modern layout, not IRC layout Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@@ -109,7 +109,6 @@ limitations under the License. | |||
position: initial; | |||
font-size: $font-14px; | |||
opacity: 1.0; | |||
color: $event-timestamp-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant as specified with https://github.com/matrix-org/matrix-react-sdk/pull/8818/files#diff-ee6630d9ea69841b23949b052300770cf30db1afe7d269d4f4e769ef49f346b5R20.
Before | After |
---|---|
@@ -196,7 +195,6 @@ limitations under the License. | |||
} | |||
|
|||
.mx_MessageTimestamp { | |||
font-size: $font-12px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max-width: 80px; | ||
width: auto; | ||
font-size: $font-12px; | ||
max-width: var(--MessageTimestamp-max-width); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.mx_MessageTimestamp { | ||
font-size: $font-10px; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1027,6 +1020,7 @@ $threadInfoLineHeight: calc(2 * $font-12px); // See: _commons.scss | |||
|
|||
.mx_MessageTimestamp { | |||
top: 2px; // Align with mx_EventTile_content | |||
position: absolute; // for IRC layout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
color: $secondary-content; | ||
display: unset; | ||
width: unset; // Cancel the default width value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
color: $event-timestamp-color; | ||
font-size: $font-10px; | ||
font-variant-numeric: tabular-nums; | ||
display: block; // enable the width setting below |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because width
declaration below is supposed to be enabled by default.
.mx_MessageTimestamp { | ||
width: unset; // Cancel the default width | ||
max-width: var(--MessageTimestamp-max-width); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…into MessageTimestamp
@@ -849,6 +849,7 @@ $threadInfoLineHeight: calc(2 * $font-12px); // See: _commons.scss | |||
.mx_MessageTimestamp { | |||
font-size: $font-12px; | |||
max-width: var(--MessageTimestamp-max-width); | |||
position: initial; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the conflict. |
This PR sets common width, white-space, and display value to
mx_MessageTimestamp
, adding the class name tomx_PinnedEventTile_timestamp
.type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
This change is marked as an internal change (Task), so will not be included in the changelog.