This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Remove unique settings from labs user settings tab #8828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
bot
added
Z-Community-PR
weeman1337
suggested changes
Jun 13, 2022
There was a problem hiding this comment.
Hi @luixxiul thank you for your contribution!
Can you check my comment and re-request review after resolving it?
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
luixxiul
commented
Jun 13, 2022
|
I am actually not really satisfied with the naming |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unique settings from
_LabsUserSettingsTab.scssin order to make the spacing same as the other tabs, other than the setting which specifies the toggle switch position.type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
This change is marked as an internal change (Task), so will not be included in the changelog.