This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make cypress tests for spotlight less flaky #8856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justjanne
added
the
T-Task
turt2live
approved these changes
Jun 16, 2022
| // our debouncing logic only starts the search after a short timeout, | ||
| // so we wait a few milliseconds. | ||
| cy.wait(300); | ||
| cy.get(".mx_Spinner").should("not.exist").then(() => { |
There was a problem hiding this comment.
Cypress doesn't really behave like a promise interface, despite exposing a promise interface, but it doesn't hurt anything.
In theory should be able to just stack the calls and it'll figure it out.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Task
Related: #8707
This change is marked as an internal change (Task), so will not be included in the changelog.