Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix read receipts group position on TimelineCard in compact modern/group layout #8971

Merged
merged 2 commits into from
Jul 2, 2022
Merged

Fix read receipts group position on TimelineCard in compact modern/group layout #8971

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fee6a59
Use variables for read receipts group position on TimelineCard in com…
luixxiul Jul 1, 2022
e76619b
Explain the reason why the rule is necessary
luixxiul Jul 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions res/css/views/right_panel/_TimelineCard.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ limitations under the License.

&[data-layout=irc],
&[data-layout=group] {
--TimelineCard_ReadReceiptGroup-inset-block-start: -6px;

&.mx_EventTile_info .mx_EventTile_line,
.mx_EventTile_line {
padding: var(--BaseCard_EventTile_line-padding-block) var(--BaseCard_EventTile-spacing-inline);
Expand Down Expand Up @@ -97,6 +99,10 @@ limitations under the License.
margin-inline-end: $spacing-8; // See: var(--ThreadView_group_spacing-end) for ReactionsRow on _EventTile.scss
}

.mx_ReadReceiptGroup {
top: var(--TimelineCard_ReadReceiptGroup-inset-block-start);
}

.mx_ThreadSummary {
margin-inline-end: 0;
max-width: min(calc(100% - 36px), 600px);
Expand All @@ -110,6 +116,15 @@ limitations under the License.
}
}

&[data-layout=group] {
// Read receipt group on compact modern layout
// This is required because mx_TimelineCard is a child element wrapped by mx_MatrixChat_useCompactLayout,
// which specifies the default position of mx_ReadReceiptGroup on compact modern layout.
.mx_MatrixChat_useCompactLayout & .mx_ReadReceiptGroup {
top: var(--TimelineCard_ReadReceiptGroup-inset-block-start);
SimonBrandner marked this conversation as resolved.
Show resolved Hide resolved
}
}

&[data-layout=bubble] {
&::before {
z-index: auto; // enable background color on hover
Expand Down Expand Up @@ -141,10 +156,6 @@ limitations under the License.
}
}

.mx_ReadReceiptGroup {
top: -6px;
}

.mx_WhoIsTypingTile {
margin-left: -12px; // undo padding on the message list
}
Expand Down