Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Move mx_EventTile_msgOption out of mx_EventTile:not([data-layout=bubble]) #8973

Merged
merged 3 commits into from
Jul 5, 2022
Merged

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jul 2, 2022

This PR moves mx_EventTile_msgOption out of mx_EventTile:not([data-layout=bubble]). This change should not affect something outside of the chat panel, as the element is hidden with display:none there (FontScalingPanel, LayoutSwitcher, etc).

Before After
IRC layout before1 after1
Modern layout before2 after2

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

type: task


This change is marked as an internal change (Task), so will not be included in the changelog.

luixxiul added 2 commits July 2, 2022 23:55
…le])

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Jul 2, 2022
@luixxiul luixxiul marked this pull request as ready for review July 2, 2022 15:41
@luixxiul luixxiul requested a review from a team as a code owner July 2, 2022 15:41
@luixxiul luixxiul requested review from dbkr, t3chguy and weeman1337 July 2, 2022 15:41
@@ -39,7 +39,7 @@ $irc-line-height: $font-18px;
margin-right: $right-padding;
}

> .mx_EventTile_msgOption {
.mx_EventTile_msgOption {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without :not() pseudo class, it is no longer required to increase specificity.

Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the Netlify Deployment. LGTM

@weeman1337 weeman1337 merged commit 4b624fd into matrix-org:develop Jul 5, 2022
@luixxiul luixxiul deleted the positivism5 branch July 5, 2022 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants