This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Replace MSC3244 support with in-client room version checking #9018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
added
the
T-Task
turt2live
requested review from
SimonBrandner
and removed request for
andybalaam and
duxovni
SimonBrandner
approved these changes
Jul 8, 2022
t3chguy
reviewed
Jul 8, 2022
| }, | ||
| }); | ||
| } | ||
| createOpts.room_version = PreferredRoomVersions.RestrictedRooms; |
There was a problem hiding this comment.
Surely we ought to be checking IRoomVersionsCapability::available here otherwise we'll be asking for the server to create a room of a version it doesn't support and exploding
@turt2live this is a release blocker IMO
There was a problem hiding this comment.
from oob context: we could check available (and probably should), but realistically v9 has been out for so long that users shouldn't run into issues. We should also make the client extremely clear in what it needs from the server, per element-hq/element-web#22346
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with matrix-org/matrix-js-sdk#2504
Fixes element-hq/element-web#22775
As of writing, the MSC is in FCP for rejection: matrix-org/matrix-spec-proposals#3244
This change is marked as an internal change (Task), so will not be included in the changelog.