This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Remove mx_EventTile:not([data-layout="bubble"]) selector
#9033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Z-Community-PR
3 tasks
3 tasks
luixxiul
commented
Mar 16, 2023
| @@ -403,7 +408,7 @@ $left-gutter: 64px; | |||
| } | |||
|
|
|||
| &.mx_EventTile_continuation { | |||
| padding-top: 0px !important; | |||
There was a problem hiding this comment.
!important has been required due to https://github.com/matrix-org/matrix-react-sdk/pull/9033/files#diff-5d3e25eb1d22dd7a96e0e87ea9c1298dc7dbce8eb965d30b2d1ebc1436bfec3fL484 inside :not()
This was referenced Mar 17, 2023
3 tasks
merging style rules on _EventBubbleTile.scss Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
While mx_EventTile:not([data-layout="bubble"]) suggests that "clear: both" would not be applied to the bubble layout, the value "both" has been in fact luckily applied thanks to "mx_RoomView_MessageList li" on _RoomView.pcss, imported later than _EventTile.pcss. Since "clear: both" is declared for mx_EventTile, this declaration is no longer needed here. Though the value of that declaration of mx_EventTile on the timeline (including ThreadView) seems to have been overridden by "mx_RoomView_MessageList li" for all layouts, it should not be removed yet until E2E tests which check visual regressions are implemented, in order to minimize the risk of a regression outside of the timeline. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
luixxiul
changed the title
mx_EventTile:not([data-layout="bubble"]) selector
richvdh
reviewed
Apr 26, 2023
richvdh
approved these changes
Apr 26, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The issue will be fixed by #10715. |
|
finally! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes element-hq/element-web#24864
This PR intends to move declarations out of
mx_EventTile:not([data-layout="bubble"])to remove the selector and to make it easy to editEventTilestyle rules without "hacks" to override the rules with increased specificity due to:not()pseudo class, merging the style rules on_EventBubbleTile.scss.Because the rules inside
mx_EventTile:not([data-layout="bubble"])have been applied anywhere exceptmx_EventTile[data-layout="bubble"]even outside of the main timeline, such as on FilePanel. Therefore, this PR suggests to apply the declarations globally first and then cancel what has not been applied to bubble layout. This might look redundant, but this is conservative and safer.The next task would be to clean up rules which have been added against increased specificity due to
:not()pseudo class.type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
This change is marked as an internal change (Task), so will not be included in the changelog.