Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use display name instead of user ID when rendering power events (PSC-82) #9295

Merged
merged 6 commits into from
Sep 22, 2022

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Sep 20, 2022

Notes: Use display name instead of user ID when rendering power events

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

  • Use display name instead of user ID when rendering power events (#9295).

@Johennes Johennes requested a review from a team as a code owner September 20, 2022 07:11
@Johennes Johennes added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Sep 20, 2022
src/TextForEvent.tsx Show resolved Hide resolved
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me

@t3chguy
Copy link
Member

t3chguy commented Sep 20, 2022

Here's what your changelog entry will look like:

✨ Features

Can we please not add the bracketed identifiers to our changelogs? They make no sense to users

@Johennes
Copy link
Contributor Author

Here's what your changelog entry will look like:

✨ Features

Can we please not add the bracketed identifiers to our changelogs? They make no sense to users

@t3chguy yes, sorry, this slipped. Have fixed the notes now.

@Johennes
Copy link
Contributor Author

Hm, should click top left of view source event toggle failed but I'm not sure how that would relate to my changes.

@t3chguy
Copy link
Member

t3chguy commented Sep 21, 2022

@Johennes element-hq/element-web#23270

@Johennes
Copy link
Contributor Author

@t3chguy did you want me to do anything else before this can be merged?

@t3chguy
Copy link
Member

t3chguy commented Sep 21, 2022

The tests need to pass to unlock the merge button, unfortunately a case of restarting and hoping until someone fixes the flake.

@Johennes
Copy link
Contributor Author

All green now 🙂

@t3chguy t3chguy merged commit 88c12cd into matrix-org:develop Sep 22, 2022
odelcroi added a commit to tchapgouv/tchap-web-v4 that referenced this pull request Oct 5, 2022
* Device manager - select all devices ([\#9330](matrix-org/matrix-react-sdk#9330)). Contributed by @kerryarchibald.
* New group call experience: Call tiles ([\#9332](matrix-org/matrix-react-sdk#9332)).
* Add Shift key to FormatQuote keyboard shortcut ([\#9298](matrix-org/matrix-react-sdk#9298)). Contributed by @owi92.
* Device manager - sign out of multiple sessions ([\#9325](matrix-org/matrix-react-sdk#9325)). Contributed by @kerryarchibald.
* Display push toggle for web sessions (MSC3890) ([\#9327](matrix-org/matrix-react-sdk#9327)).
* Add device notifications enabled switch ([\#9324](matrix-org/matrix-react-sdk#9324)).
* Implement push notification toggle in device detail ([\#9308](matrix-org/matrix-react-sdk#9308)).
* New group call experience: Starting and ending calls ([\#9318](matrix-org/matrix-react-sdk#9318)).
* New group call experience: Room header call buttons ([\#9311](matrix-org/matrix-react-sdk#9311)).
* Make device ID copyable in device list ([\#9297](matrix-org/matrix-react-sdk#9297)). Contributed by @duxovni.
* Use display name instead of user ID when rendering power events ([\#9295](matrix-org/matrix-react-sdk#9295)).
* Read receipts for threads ([\#9239](matrix-org/matrix-react-sdk#9239)). Fixes #23191.
* Fix device selection in pre-join screen for Element Call video rooms ([\#9321](matrix-org/matrix-react-sdk#9321)). Fixes #23331.
* Don't render a 1px high room topic if the room topic is empty ([\#9317](matrix-org/matrix-react-sdk#9317)). Contributed by @Arnei.
* Don't show feedback prompts when that UIFeature is disabled ([\#9305](matrix-org/matrix-react-sdk#9305)). Fixes #23327.
* Fix soft crash around unknown room pills ([\#9301](matrix-org/matrix-react-sdk#9301)). Fixes matrix-org/element-web-rageshakes#15465.
* Fix spaces feedback prompt wrongly showing when feedback is disabled ([\#9302](matrix-org/matrix-react-sdk#9302)). Fixes #23314.
* Fix tile soft crash in ReplyInThreadButton ([\#9300](matrix-org/matrix-react-sdk#9300)). Fixes matrix-org/element-web-rageshakes#15493.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants