Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Extract createVoiceMessageContent #9322

Merged
merged 6 commits into from
Sep 29, 2022
Merged

Extract createVoiceMessageContent #9322

merged 6 commits into from
Sep 29, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Sep 28, 2022 •
edited
Loading

Part of element-hq/element-web#23282

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Sep 28, 2022
@weeman1337 weeman1337 force-pushed the weeman1337/extract-create-voice-message-content branch from ff39e0f to ddafa07 Compare September 28, 2022 08:16
@weeman1337 weeman1337 marked this pull request as ready for review September 28, 2022 09:46
@weeman1337 weeman1337 requested a review from a team as a code owner September 28, 2022 09:46
@weeman1337 weeman1337 enabled auto-merge (squash) September 28, 2022 12:52
turt2live
turt2live approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally we shouldn't use snapshots for object tests, but also for this the event type is... complicated.

@weeman1337 weeman1337 merged commit 7a33818 into develop Sep 29, 2022
@weeman1337 weeman1337 deleted the weeman1337/extract-create-voice-message-content branch September 29, 2022 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@turt2live turt2live turt2live approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weeman1337 @turt2live