Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Inhibit local notifications when local notifications are silenced #9328

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Inhibit local notifications when local notifications are silenced #9328

merged 4 commits into from
Sep 29, 2022

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Sep 29, 2022 •
edited by github-actions bot
Loading

Fixes https://element-io.atlassian.net/browse/PSG-712

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@germain-gg germain-gg added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Sep 29, 2022
@germain-gg germain-gg requested a review from a team as a code owner September 29, 2022 08:02
This was referenced Sep 29, 2022
Closed
Closed
kerryarchibald
kerryarchibald approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀 LGTM
Tested the deployment, works as expected

test/test-utils/MockPlatform.ts Outdated Show resolved Hide resolved
@germain-gg germain-gg enabled auto-merge (squash) September 29, 2022 10:55
@germain-gg germain-gg merged commit a49603b into develop Sep 29, 2022
@germain-gg germain-gg deleted the gsouquet/silence-notifications-psg-712 branch September 29, 2022 14:23
@t3chguy t3chguy mentioned this pull request Sep 30, 2022
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kerryarchibald kerryarchibald kerryarchibald approved these changes

@turt2live turt2live Awaiting requested review from turt2live turt2live is a code owner automatically assigned from matrix-org/element-web-reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germain-gg @kerryarchibald