Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

When start listening to a broadcast, pause the others #9489

Merged
merged 1 commit into from
Oct 24, 2022
Merged

When start listening to a broadcast, pause the others #9489

merged 1 commit into from
Oct 24, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Oct 24, 2022 •
edited
Loading

Part of element-hq/element-web#23282

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 24, 2022
@weeman1337 weeman1337 marked this pull request as ready for review October 24, 2022 14:00
@weeman1337 weeman1337 requested a review from a team as a code owner October 24, 2022 14:00
t3chguy
t3chguy approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane

@weeman1337 weeman1337 merged commit d702f4a into develop Oct 24, 2022
@weeman1337 weeman1337 deleted the weeman1337/voice-broadcast-single-playback branch October 24, 2022 14:07
weeman1337 added a commit that referenced this pull request Oct 26, 2022
@weeman1337
When start listening to a broadcast, pause the others (#9489)
ec093c9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

@duxovni duxovni Awaiting requested review from duxovni duxovni is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weeman1337 @t3chguy