Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Mute notifications for broadcast chunks #9852

Merged
merged 8 commits into from
Jan 6, 2023
Merged

Mute notifications for broadcast chunks #9852

merged 8 commits into from
Jan 6, 2023

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Jan 3, 2023 •
edited by github-actions bot
Loading

closes element-hq/element-web#24101

PSF-1816

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jan 3, 2023
@weeman1337 weeman1337 marked this pull request as ready for review January 3, 2023 10:17
@weeman1337 weeman1337 requested a review from a team as a code owner January 3, 2023 10:17
@t3chguy
Copy link
Member

t3chguy commented Jan 3, 2023

@weeman1337 this doesn't look ready for review based on the failing CI

@weeman1337 weeman1337 marked this pull request as draft January 3, 2023 11:05
germain-gg
germain-gg approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@weeman1337 weeman1337 marked this pull request as ready for review January 3, 2023 17:09
@weeman1337
Copy link
Contributor Author

Rolled back some type script strict fixes due to code coverage failing then 🙁
There is still a type script error checker fail of code that I didn't change.

@andybalaam andybalaam merged commit bfe219b into develop Jan 6, 2023
@andybalaam andybalaam deleted the weeman1337/mute-broadcast-notifications branch January 6, 2023 02:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

@artcodespace artcodespace Awaiting requested review from artcodespace artcodespace is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore the voice broadcast chunks at the notifications level
4 participants
@weeman1337 @t3chguy @germain-gg @andybalaam