Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CTRL+Backspace behaviour on Windows #751

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Conversation

germain-gg
Copy link
Contributor

Fixes https://github.com/vector-im/verticals-internal/issues/102

Add an operating system detection function based on the user agent. And processes input events differently based on the user OS.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.25% ⚠️

Comparison is base (3b15882) 90.20% compared to head (49a9ccd) 89.95%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   90.20%   89.95%   -0.25%     
==========================================
  Files         111       82      -29     
  Lines       16115    14674    -1441     
  Branches      565        0     -565     
==========================================
- Hits        14536    13200    -1336     
+ Misses       1558     1474      -84     
+ Partials       21        0      -21     
Flag Coverage Δ
uitests ?
uitests-ios ?
unittests 89.95% <ø> (+0.83%) ⬆️
unittests-ios ?
unittests-rust 89.95% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@germain-gg germain-gg changed the title Add getUserOperatingSystem util Fix CTRL+Backspace behaviour on Windows Jul 26, 2023
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor suggestions

platforms/web/lib/utils.ts Outdated Show resolved Hide resolved
platforms/web/lib/useListeners/event.test.ts Outdated Show resolved Hide resolved
germain-gg and others added 2 commits July 26, 2023 15:28
Co-authored-by: Florian Duros <florianduros@element.io>
@germain-gg germain-gg requested a review from langleyd July 26, 2023 14:36
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@germain-gg germain-gg merged commit a2e82b3 into main Jul 26, 2023
7 checks passed
@germain-gg germain-gg deleted the germain-gg/psb-369 branch July 26, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants