Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Sliding Sync to named-lists JSON upgrade #1399

Merged
merged 9 commits into from
Jan 31, 2023

Conversation

gnunicorn
Copy link
Contributor

@gnunicorn gnunicorn commented Jan 24, 2023

Upgrades the sliding sync from index-based views to named views. Additionally provides support for delta-tokens (once they are implemented) and exposes the new additional extensions to be enabled over ffi. Last but not least, it enabled gzip on reqwest for on-the-wire-compression whenever the sliding-sync feature is enabled.

Built against ruma/ruma#1460

@gnunicorn gnunicorn force-pushed the ben-upgrading-sliding-sync branch 2 times, most recently from f196d60 to a5356ac Compare January 27, 2023 12:33
@gnunicorn gnunicorn requested a review from a team January 27, 2023 13:04
@gnunicorn gnunicorn marked this pull request as ready for review January 27, 2023 13:05
@gnunicorn gnunicorn mentioned this pull request Jan 27, 2023
16 tasks
@gnunicorn gnunicorn force-pushed the ben-upgrading-sliding-sync branch from a5356ac to 04d80c2 Compare January 27, 2023 14:55
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 73.10% // Head: 73.58% // Increases project coverage by +0.48% 🎉

Coverage data is based on head (5467206) compared to base (00e93e0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1399      +/-   ##
==========================================
+ Coverage   73.10%   73.58%   +0.48%     
==========================================
  Files         116      116              
  Lines       13082    12996      -86     
==========================================
  Hits         9563     9563              
+ Misses       3519     3433      -86     
Impacted Files Coverage Δ
crates/matrix-sdk/src/sliding_sync.rs 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gnunicorn gnunicorn force-pushed the ben-upgrading-sliding-sync branch from 04d80c2 to fb07e31 Compare January 27, 2023 15:09
@gnunicorn gnunicorn mentioned this pull request Jan 27, 2023
4 tasks
crates/matrix-sdk/src/sliding_sync.rs Outdated Show resolved Hide resolved
crates/matrix-sdk/src/sliding_sync.rs Outdated Show resolved Hide resolved
crates/matrix-sdk/src/sliding_sync.rs Outdated Show resolved Hide resolved
crates/matrix-sdk/src/sliding_sync.rs Outdated Show resolved Hide resolved
crates/matrix-sdk/src/sliding_sync.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to use the shasum of the merged commit of the Ruma PR, otherwise just extraneous spaces.

Cargo.toml Outdated Show resolved Hide resolved
crates/matrix-sdk/src/sliding_sync.rs Outdated Show resolved Hide resolved
@gnunicorn gnunicorn force-pushed the ben-upgrading-sliding-sync branch from b14696b to 0e08aa7 Compare January 31, 2023 13:14
@gnunicorn gnunicorn force-pushed the ben-upgrading-sliding-sync branch from 0e08aa7 to 1df9acc Compare January 31, 2023 13:20
@gnunicorn gnunicorn enabled auto-merge (rebase) January 31, 2023 13:21
Cargo.toml Show resolved Hide resolved
@gnunicorn gnunicorn deleted the ben-upgrading-sliding-sync branch January 31, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants