Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Bindings: make unused_fallback_keys as optional in machine.rs/receive_sync_changes #1838

Merged

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Apr 27, 2023

  • Public API changes documented in changelogs (optional)

Needed in element-hq/element-web#25215

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cbfa134) 76.45% compared to head (75870dd) 76.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1838   +/-   ##
=======================================
  Coverage   76.45%   76.45%           
=======================================
  Files         140      140           
  Lines       15967    15967           
=======================================
  Hits        12207    12207           
  Misses       3760     3760           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@florianduros florianduros requested a review from a team April 28, 2023 07:44
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@poljar poljar merged commit e6f2f65 into main Apr 28, 2023
@poljar poljar deleted the florianduros/feat/optional-unused-fallback-keys-js-bindings branch April 28, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants