Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(binding): boolean to decide whether filter by push rules or not #2145

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jun 26, 2023

this is a workaround until we find a way to fix the issue described here:
element-hq/element-x-ios#1155

@Velin92 Velin92 requested a review from a team as a code owner June 26, 2023 08:28
@Velin92 Velin92 requested review from bnjbvr and jplatte and removed request for a team June 26, 2023 08:28
@jplatte jplatte enabled auto-merge (squash) June 26, 2023 08:29
@Velin92 Velin92 changed the title feat(binding): boolean to decide wether filter by push rules or not feat(binding): boolean to decide whether filter by push rules or not Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8916eb6) 76.11% compared to head (7e8a801) 76.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2145   +/-   ##
=======================================
  Coverage   76.11%   76.11%           
=======================================
  Files         163      163           
  Lines       17303    17303           
=======================================
  Hits        13170    13170           
  Misses       4133     4133           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jplatte jplatte merged commit 2c58c65 into main Jun 26, 2023
@jplatte jplatte deleted the mauroromito/boolean_to_decide_wther_to_filter_or_not branch June 26, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants