Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset the timeline when ignore user list changes #2504

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Sep 4, 2023

Supersedes #2467. Different fix, basically same test code (slightly adjusted to account for implementation differences).

@jplatte jplatte requested a review from a team as a code owner September 4, 2023 15:22
@jplatte jplatte requested review from bnjbvr and Hywan and removed request for a team and bnjbvr September 4, 2023 15:22
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-). Thanks!

@jplatte jplatte enabled auto-merge (rebase) September 4, 2023 15:26
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (cf41956) 77.39% compared to head (7b8b449) 77.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2504      +/-   ##
==========================================
+ Coverage   77.39%   77.43%   +0.04%     
==========================================
  Files         184      184              
  Lines       19510    19523      +13     
==========================================
+ Hits        15100    15118      +18     
+ Misses       4410     4405       -5     
Files Changed Coverage Δ
crates/matrix-sdk-ui/src/timeline/builder.rs 82.24% <100.00%> (+2.24%) ⬆️
crates/matrix-sdk-ui/src/timeline/mod.rs 82.02% <100.00%> (+0.10%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jplatte jplatte merged commit 465c9bc into main Sep 4, 2023
@jplatte jplatte deleted the jplatte/reset-timeline-on-ignore-list-change branch September 4, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants