Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: Fix double bootstrap #3019

Closed
wants to merge 2 commits into from
Closed

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Jan 15, 2024

Fixes #2998

Changes:

  • First commit: init cross-signing with other e2e initial task
    In existing code the bootstraping is done in different places, bootstrap_cross_signing_if_needed or run_intialization_tasks and both are based on the same EncryptionSettings. bootstrap_cross_signing_if_needed was done by LoginBuilder but run_intialization_tasks by MatrixAuth. I propose to move all under run_intialization_tasks that has already support to do it in background, and to call it in one place only: MatrixA uth

  • Second commit quick fix (dirty) to avoid having the auth client bootstraping with an in memory olmMachine before creating the final client (finalize_client)

  • Public API changes documented in changelogs (optional)

Signed-off-by:

Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said in private conversation and dev room, I don't think the workaround is fine. I appreciate you taking the time to track it down and working around it, but we have an overdue refactoring in this area of the code.

@BillCarsonFr
Copy link
Member Author

Bootstrap refactoring moved into separate PR #3024

@Hywan Hywan changed the title Valere/fix double bootstrap sdk: Fix double bootstrap Jan 22, 2024
@bnjbvr
Copy link
Member

bnjbvr commented Jan 22, 2024

Closing this one, since the workaround isn't something we want + the interesting refactoring has been split up and merged (thanks!).

@bnjbvr bnjbvr closed this Jan 22, 2024
@poljar poljar deleted the valere/fix_double_bootstrap branch November 5, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element X: Two Olm Machines created in a row with same deviceId but different keys
2 participants