Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2998
Changes:
First commit: init cross-signing with other e2e initial task
In existing code the bootstraping is done in different places,
bootstrap_cross_signing_if_needed
orrun_intialization_tasks
and both are based on the sameEncryptionSettings
.bootstrap_cross_signing_if_needed
was done byLoginBuilder
butrun_intialization_tasks
byMatrixAuth
. I propose to move all underrun_intialization_tasks
that has already support to do it in background, and to call it in one place only:MatrixA uth
Second commit quick fix (dirty) to avoid having the auth client bootstraping with an in memory olmMachine before creating the final client (
finalize_client
)Public API changes documented in changelogs (optional)
Signed-off-by: