crypto: remove the fake crypto store test for olm session wedging

[bnjbvr]

Two reviewers considered that test as not very useful, so I hereby propose to remove it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (83427b3) to head (1d88b9d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3342      +/-   ##
==========================================
- Coverage   82.96%   82.95%   -0.02%     
==========================================
  Files         245      245              
  Lines       24901    24901              
==========================================
- Hits        20660    20657       -3     
- Misses       4241     4244       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[poljar]

Let's see if we get the complement test ported, the test has some use before that's achieved.

[bnjbvr]

Oh, I thought the other test did test the same effect properly, by adding a session, regenerating the olm machine and checking that the session was then missing from the cache?

[poljar]

Oh, I thought the other test did test the same effect properly, by adding a session, regenerating the olm machine and checking that the session was then missing from the cache?

Well kinda, the other test ensures that the SqliteCryptoStore method does the correct thing, this test ensures that the regenerate_olm() method will call the method to clear the cache.

[bnjbvr]

Ah, so you're saying the SqliteCryptoStore could do the correct thing, without the method to clear the cache getting called? Then agreed, we can merge this later.

[poljar]

Ah, so you're saying the SqliteCryptoStore could do the correct thing, without the method to clear the cache getting called? Then agreed, we can merge this later.

Yeah, we might accidentally remove the call to this method and the dumb test ensures that we don't do so.

[poljar]

This depends on #3343.

[bnjbvr]

@poljar now that #3343 has been merged, can haz review plz? 🥺

[poljar]

Very elegant removal, more of this please.