clippy: fix extra errors and enforce target-applies-to-host in xtask
#3497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the configs from `.cargo/config.toml` were not read in CI tasks, causing false positives when running Clippy on CI (i.e. there were issues observed when compiling locally that were not found when compiling remotely). Not entirely sure why it's needed, because I'm seeing the issues when I'm using `cargo xtask ci clippy` locally, with nothing changed.
bnjbvr
force-pushed
the
bnjbvr/fix-local-clippy-errors
branch
from
0175cdf to
276b6d7
Compare
We should investigate why some errors were not found in CI tasks, though.
bnjbvr
force-pushed
the
bnjbvr/fix-local-clippy-errors
branch
from
276b6d7 to
313af41
Compare
bnjbvr
changed the title
target-applies-to-host in xtask
bnjbvr
requested review from
Hywan,
jplatte and
a team
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3497 +/- ##
=======================================
Coverage 83.73% 83.73%
=======================================
Files 255 255
Lines 25778 25778
=======================================
Hits 21584 21584
Misses 4194 4194 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enforces the env variable to set the
--target-applies-to-hostsetting when running in xtask. I'm not sure why it's required, but without it, the CI step didn't find all the issues that I could find locally. @jplatte if you have any idea about that, I'd be curious; I've mostly cargo culted the existing workaround used when building the doc. It looks like another instance of rust-lang/cargo#10744 in a slightly different context.The second commit fixes the issues found by clippy.