-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cache the computed display name and reuse that in the search filters #3516
Commits on Jun 6, 2024
-
base: directly call
calculate_room_name
since it's a free-functionInstead of calling it through `BaseRoomInfo::calculate_room_name`.
Configuration menu - View commit details
-
Copy full SHA for 751ddd6 - Browse repository at this point
Copy the full SHA 751ddd6View commit details -
base: fix guessed number of members as it should relate to joined use…
…rs, not joined+invited The previous code would use `ACTIVE` which means "either joined or invited" members, but the code thereafter considered this to be the number of joined members. Also replaced a call to `self.members()` (which does a lot of work under the hood) with a call to `self.joined_user_ids()`, since we only retrieve the `.len()` of the resulting vector.
Configuration menu - View commit details
-
Copy full SHA for 8efcf4e - Browse repository at this point
Copy the full SHA 8efcf4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cddc2b1 - Browse repository at this point
Copy the full SHA cddc2b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3221703 - Browse repository at this point
Copy the full SHA 3221703View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e075d3 - Browse repository at this point
Copy the full SHA 0e075d3View commit details -
base: make
get_or_create_room
asyncSince this is a good place where to recompute the cached display name at start.
Configuration menu - View commit details
-
Copy full SHA for 60f5d8d - Browse repository at this point
Copy the full SHA 60f5d8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c790bd - Browse repository at this point
Copy the full SHA 4c790bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 256d7b3 - Browse repository at this point
Copy the full SHA 256d7b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22911dd - Browse repository at this point
Copy the full SHA 22911ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9021c18 - Browse repository at this point
Copy the full SHA 9021c18View commit details -
base: rename computed_display_name to compute_display_name and remove…
… computed_ in the cached one
Configuration menu - View commit details
-
Copy full SHA for 823226a - Browse repository at this point
Copy the full SHA 823226aView commit details -
ci: fix flakeyness of
test_room_notification_count
in an innovative…… way The test looks at updates of `RoomInfo`s, but these depends on external factors like the server sending them in one part or multiple ones. Instead of trying to figure out which partial updates the server sent, wait for the stream of `RoomInfo`s to stabilize by trying to get the latest item from the stream, then wait up to N seconds for another item to show up, and continue as long as items come in. This should allow us to get rid of some code that was required to prevent flakey updates.
Configuration menu - View commit details
-
Copy full SHA for cd65997 - Browse repository at this point
Copy the full SHA cd65997View commit details
Commits on Jun 10, 2024
-
base: don't regenerate the display name when creating a room, store t…
…he cached display name in RoomInfo So revert a few changes to make some functions async, etc.
Configuration menu - View commit details
-
Copy full SHA for e96d932 - Browse repository at this point
Copy the full SHA e96d932View commit details -
base: move the initial filling of the display name cache into the syn…
…c methods It's not perfect, but it's honest work.
Configuration menu - View commit details
-
Copy full SHA for 5001b27 - Browse repository at this point
Copy the full SHA 5001b27View commit details