Client Builder: Add support for requiring Sliding Sync. #3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3569 +/- ##
==========================================
+ Coverage 83.79% 83.84% +0.04%
==========================================
Files 253 253
Lines 25900 25905 +5
==========================================
+ Hits 21704 21719 +15
+ Misses 4196 4186 -10 ☔ View full report in Codecov by Sentry. |
pixlwave
force-pushed
the
doug/requires-sliding-sync
branch
from
8863f8a to
66b00ff
Compare
poljar
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small part of #3029 that moves (and tests) the check for mandatory sliding sync from the FFI into the SDK with the use of a
ClientBuilder::requires_sliding_syncmethod.