Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(base): Use constructors of SyncTimelineEvent to simplify code #3615

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Jun 26, 2024

Extracted from #3585. Just a simple refactoring.

@Hywan Hywan requested a review from a team as a code owner June 26, 2024 15:00
@Hywan Hywan requested review from poljar and removed request for a team June 26, 2024 15:00
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.88%. Comparing base (748f40c) to head (d59b28e).
Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3615      +/-   ##
==========================================
+ Coverage   83.86%   83.88%   +0.01%     
==========================================
  Files         254      254              
  Lines       26104    26105       +1     
==========================================
+ Hits        21893    21897       +4     
+ Misses       4211     4208       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should replace uses of sync_timeline_event!() by using the EventFactory directly, since it usually reads better IMO at call sites, but this works too :)

@bnjbvr bnjbvr removed the request for review from poljar June 26, 2024 16:18
@Hywan Hywan merged commit 37c125c into matrix-org:main Jun 27, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants