event cache: add a way to get an event by ID #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
force-pushed
the
bnjbvr/event-cache-find-event-by-id
branch
from
838087f to
4f19836
Compare
poljar
approved these changes
Jul 10, 2024
| @@ -196,6 +196,24 @@ impl EventCache { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Try to find an event by id in all the rooms. | |||
There was a problem hiding this comment.
Perhaps we should clarify by which ID, if you don't like this form perhaps spelling out the term "event ID" would be better?
Suggested change
| /// Try to find an event by id in all the rooms. | |
| /// Try to find an event by its ID in all the rooms. |
| /// Try to find an event by id in all the rooms. | ||
| /// | ||
| /// Note: this does a linear scan, so it could be slow. If performance | ||
| /// requires it, using a direct mapping of event id -> event might be |
There was a problem hiding this comment.
Does this tell the user that they should create such a mapping or that we, the developers, will provide it if this method turns out to be slow?
There was a problem hiding this comment.
You're right, it's unclear. We should do that, if needs be; i'll convert this into a code non-doc comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3682 +/- ##
==========================================
+ Coverage 84.32% 84.36% +0.04%
==========================================
Files 258 258
Lines 26614 26615 +1
==========================================
+ Hits 22441 22455 +14
+ Misses 4173 4160 -13 ☔ View full report in Codecov by Sentry. |
bnjbvr
force-pushed
the
bnjbvr/event-cache-find-event-by-id
branch
from
4f19836 to
d96c72a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"dude… what if the event cache… allowed to retrieve events by id… i know, it's crazy right…"
This is going to be useful for #3663, for edits we'll want to retrieve the original event by id, to see if it was a reply, and some other things like this.
Part of #3058 too.