Crypto: add helper methods to UserIdentities
#3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/own_verification_violation
branch
from
301595e to
9b66b62
Compare
richvdh
force-pushed
the
rav/user_identity_helpers
branch
from
ce3e08c to
8dbfcda
Compare
richvdh
force-pushed
the
rav/own_verification_violation
branch
from
64ac50a to
ae2f0f7
Compare
richvdh
force-pushed
the
rav/user_identity_helpers
branch
from
8dbfcda to
e9dc0ba
Compare
1 task
We have a bunch of methods which are the same in both `OtherUserIdentity` and `OwnUserIdentity`, so add some convenience methods to access them.
richvdh
force-pushed
the
rav/user_identity_helpers
branch
2 times, most recently
from
580c489 to
9102ef9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3847 +/- ##
==========================================
+ Coverage 84.10% 84.13% +0.02%
==========================================
Files 262 262
Lines 27637 27651 +14
==========================================
+ Hits 23245 23263 +18
+ Misses 4392 4388 -4 ☔ View full report in Codecov by Sentry. |
andybalaam
approved these changes
Aug 16, 2024
| @@ -2213,43 +2208,30 @@ pub(crate) mod tests { | |||
| let own_identity = | |||
| machine.get_identity(DataSet::own_id(), None).await.unwrap().unwrap().own().unwrap(); | |||
There was a problem hiding this comment.
This line looks similar: can it be simplified too?
There was a problem hiding this comment.
no. We need to call own_identity.is_identity_signed(); is_identity_signed is specific to OwnUserIdentity.
... instead of lots of `match` and `own()` and `other()`.
richvdh
force-pushed
the
rav/user_identity_helpers
branch
from
67b221a to
93ca5fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bunch of methods which are the same in both
OtherUserIdentityandOwnUserIdentity, so add some convenience methods to access them.