Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ci): Re-enable Complement Crypto #4249

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Nov 12, 2024

@Hywan Hywan requested a review from a team as a code owner November 12, 2024 09:31
@Hywan Hywan requested review from bnjbvr and removed request for a team November 12, 2024 09:31
@Hywan Hywan enabled auto-merge (rebase) November 12, 2024 09:37
@poljar
Copy link
Contributor

poljar commented Nov 12, 2024

Please don't disable complement crypto in the future anymore, if there is an API break open a PR on complement-crypto with the same branch name as your SDK PR.

That way the github action in the SDK will use complement crypto from the PR with the updated API, then CI on the SDK will pass and you can merge both PRs at the same time.

@Hywan Hywan merged commit 66a7972 into matrix-org:main Nov 12, 2024
40 checks passed
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.93%. Comparing base (403be3d) to head (781d22e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4249   +/-   ##
=======================================
  Coverage   84.93%   84.93%           
=======================================
  Files         274      274           
  Lines       29726    29726           
=======================================
  Hits        25247    25247           
  Misses       4479     4479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hywan
Copy link
Member Author

Hywan commented Nov 12, 2024

Alrighty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants