Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an authentication service to the FFI #820
Add an authentication service to the FFI #820
Changes from all commits
0178b71
56adf6a
91427b8
fec879f
9925d73
da277c4
0dee880
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so you create a
Client
with a fake user to get some metadata about the server. Then you set the correct user here. Am I getting this right?It might make sense to modify the
Client
in the bindings to support memory only operation. I guess it isn't that important since the store will only be used once you log in.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's correct, it's totally a workaround 🙈. Jonas and Ben had a conversation around whether the client store should be set at all until after login has succeeded. Amongst other things this would help if the user ID returned by the homeserver differed to what was used to log in.
This all seemed like it was a larger thought than just the bindings to me, so I opted for this for now. However if its something I could address in this PR, would be happy to be given some direction and have a go 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well we used to have an API where you just pass an optional store path to the Client, similarly to what the FFI
Client
does. Maybe we should just bring that back, of course only if thesled
feature is enabled.In any case, I'm not sure what we should do, so let's leave bigger changes around this for another time.