Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"edu_type" should be "type" #1143

Closed
jevolk opened this issue Mar 5, 2018 · 3 comments
Closed

"edu_type" should be "type" #1143

jevolk opened this issue Mar 5, 2018 · 3 comments
Labels
s2s Server-to-Server API (federation) wart A point where the protocol is inconsistent or inelegant

Comments

@jevolk
Copy link
Contributor

jevolk commented Mar 5, 2018

For consistency. They're also already in the edus array.

@maxidorius
Copy link
Contributor

Where exactly do you see it?

@jevolk
Copy link
Contributor Author

jevolk commented Mar 5, 2018

Where exactly do you see it?

@maxidor It's in Section 5 and the Synapse implementation. This is not a documentation error. There is just no reason to call it edu_type rather than just type. The latter puts the object on its way to being a proper event while the former precludes that. Consider content is not called edu_content, etc...

@richvdh richvdh added the wart A point where the protocol is inconsistent or inelegant label Mar 6, 2018
@turt2live turt2live added the s2s Server-to-Server API (federation) label Jul 10, 2018
@richvdh
Copy link
Member

richvdh commented Nov 18, 2021

It is annoying, but I don't think it's a pressing thing to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s2s Server-to-Server API (federation) wart A point where the protocol is inconsistent or inelegant
Projects
None yet
Development

No branches or pull requests

4 participants