Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document message formats as-is #1397

Merged
merged 2 commits into from
Jul 11, 2018

Conversation

turt2live
Copy link
Member

This is likely to later be replaced by mixins (#1225), however this is being documented now so clients aren't left in the dark.

Fixes #917

This PR documents existing behaviour and does not attempt to improve or change the situation.

This is likely to later be replaced by mixins, however this is being documented now so clients aren't left in the dark.

Fixes matrix-org#917
@turt2live
Copy link
Member Author

turt2live commented Jul 10, 2018

This is blocked on #1389 (but can still receive review)

@turt2live
Copy link
Member Author

@mujx and/or @KitsuneRal - would be nice to get your approval on this one

Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally :) thanks!

@mujx
Copy link
Contributor

mujx commented Jul 11, 2018

Do we have some extra info on the format of formatted_body? Is it a subset of HTML?

@t3chguy
Copy link
Member

t3chguy commented Jul 11, 2018

It's what the format key specifies

@t3chguy
Copy link
Member

t3chguy commented Jul 11, 2018

You're probably referring to "org.matrix.custom.html"'s formatted_body and yes that is a subset of HTML but is also a stopgap as far as I am aware

@turt2live turt2live merged commit 808a82e into matrix-org:master Jul 11, 2018
@turt2live turt2live deleted the travis/text-format branch July 11, 2018 14:10
RiotTranslateBot pushed a commit to RiotTranslateBot/matrix-doc that referenced this pull request Aug 22, 2023
* Change default room version from 9 to 10 in accordance with MSC3904

* Add changelog entry with assumed PR number.

* Fix missing comma in changelog.

Co-authored-by: Travis Ralston <travpc@gmail.com>

Co-authored-by: Travis Ralston <travpc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants