-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify how to handle multiple olm sessions with the same device #1596
Conversation
use the session from which it last received a message. A client may expire old | ||
sessions by defining a maximum number of olm sessions that it will maintain for | ||
each device, and expiring sessions on a Least Recently Used basis. The maximum | ||
number of olm sessions maintained per device should be at least 4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if 4 is the right number here, but I think that it will handle the case where two clients keep alternating between two sessions because they send each other messages at the same time, and then they both decide that they need to start new sessions (e.g. because the old sessions are wedged).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is looking to spec something sane, rather than what is currently implemented? (because I'm pretty sure this is not what is implemented).
If so, it lgtm.
Yup, the current behaviour does not match the proposed spec, so the behaviour will need to be changed. |
Implements matrix-org/matrix-spec-proposals#1596 For element-hq/element-web#3822 Requires matrix-org/olm-backup#77 (+release)
Fixes #892