Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC1983: Supporting a reason for leaving rooms #1983

Merged
merged 2 commits into from
Oct 15, 2019
Merged

MSC1983: Supporting a reason for leaving rooms #1983

merged 2 commits into from
Oct 15, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Apr 30, 2019 •
edited
Loading

Rendered
Fixes #1295

@turt2live turt2live added proposal A matrix spec change proposal proposal-in-review labels Apr 30, 2019
@turt2live turt2live changed the title Proposal to support a reason for leaving rooms MSC1983: Supporting a reason for leaving rooms Apr 30, 2019
@Half-Shot
Copy link
Contributor

Half-Shot commented May 8, 2019 •
edited
Loading

This seems reasonable :)

Worth pointing out that most (irc, discord) bridges just do a self-kick with a reason to support this behavior already, so formally supporting it seems like a sensible move.

@ara4n
Copy link
Member

ara4n commented Aug 31, 2019

this would also be very useful when deactivating users to give a reason for why they mysteriously leave the room

@ara4n
Copy link
Member

ara4n commented Aug 31, 2019

this would also be useful for rejecting invites with a unilateral reason.

@ara4n
Copy link
Member

ara4n commented Aug 31, 2019

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Aug 31, 2019 •
edited by dbkr
Loading

Team member @ara4n has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once at least 75% of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Aug 31, 2019
@aaronraimist
Copy link
Contributor

aaronraimist commented Oct 1, 2019 •
edited
Loading

Could we also maybe get a reason for invites? Being able to peek into rooms you've been invited to would be nicer but for now maybe being able to see the reason for receiving an invite would be helpful. Random people often start DMs with me and It would be nice to know what they want before joining.

@turt2live
Copy link
Member Author

Reasons for invites is just slightly more complicated and would be best served as its own MSC.

anoadragon453
anoadragon453 reviewed Oct 7, 2019
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple a straightforward, just a couple questions.

proposals/1983-leave-reasons.md Show resolved Hide resolved
proposals/1983-leave-reasons.md Show resolved Hide resolved
@anoadragon453
Copy link
Member

Looks sane and useful, thanks!

@mscbot reviewed

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Oct 7, 2019
@mscbot
Copy link
Collaborator

mscbot commented Oct 7, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@turt2live
Copy link
Member Author

/me pokes mscbot

@mscbot mscbot added finished-final-comment-period and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Oct 15, 2019
@mscbot
Copy link
Collaborator

mscbot commented Oct 15, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@turt2live turt2live merged commit 7236f1c into master Oct 15, 2019
@Half-Shot
Copy link
Contributor

In hindsight, it would probably have been useful to spell out that /leave would now take an optional body (I'm assuming) with a reason key. We don't actually spell out reason for m.room.member anywhere other than the description of /kick.

@turt2live
Copy link
Member Author

@Half-Shot sounds like a very easy future MSC ;)

@turt2live turt2live self-assigned this Oct 17, 2019
@uhoreg uhoreg mentioned this pull request Nov 26, 2019
Merged
@turt2live
Copy link
Member Author

@Half-Shot that happened, btw: #2367

@turt2live turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Apr 20, 2020
@turt2live turt2live deleted the travis/msc/leave-reason branch May 1, 2021 01:32
@turt2live
Copy link
Member Author

This was technically considered merged ages ago under #2367

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed finished-final-comment-period labels May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot left review comments

@anoadragon453 anoadragon453 anoadragon453 left review comments

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees

@turt2live turt2live

Labels
disposition-merge kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leave rooms with a reason?
8 participants
@turt2live @Half-Shot @ara4n @mscbot @aaronraimist @anoadragon453 @KitsuneRal @richvdh