Code

MSC2246: Asynchronous media uploads#2246

Code

Merged

turt2live merged 30 commits intomatrix-org:old_mastermatrix-org/matrix-spec-proposals:old_masterfrom tulir:asynchronous_uploadstulir/matrix-spec-proposals:asynchronous_uploadsCopy head branch name to clipboardApr 25, 2023

+152

Commits

Commits on Aug 24, 2019

• Proposal for asynchronous media uploads

  Show description for b439277
  tulir

  committed
  b439277

  Copy full SHA for b439277

• Add security consideration and mention possible /create request body

  Show description for a83c79c
  tulir

  committed
  a83c79c

  Copy full SHA for a83c79c

Commits on Aug 25, 2019

• Expand on security consideration

  tulir

  committed
  9a395ed

  Copy full SHA for 9a395ed

Commits on Aug 26, 2019

• Change error code for existing media PUT

  Show description for 29e3463
  

  tulir

  and

  turt2live

  authored
  29e3463

  Copy full SHA for 29e3463

• Add spam prevention error, example response and auth requirements

  tulir

  committed
  7cf22be

  Copy full SHA for 7cf22be

Commits on Aug 1, 2020

• Add query parameters to control downloading

  tulir

  committed
  658aac8

  Copy full SHA for 658aac8

• Rename max_stall to max_stall_ms

  tulir

  committed
  bbd7d08

  Copy full SHA for bbd7d08

• Merge branch 'master' into asynchronous_uploads

  tulir

  committed
  0bffcb7

  Copy full SHA for 0bffcb7

• Specify /create request body content

  tulir

  committed
  4d009a9

  Copy full SHA for 4d009a9

Commits on Mar 14, 2022

• Update links, versions and prefixes

  tulir

  committed
  1cbc04e

  Copy full SHA for 1cbc04e

• Add recommended maximum delay for starting upload

  tulir

  committed
  c65f2bf

  Copy full SHA for c65f2bf

• Explicitly deny uploading to other users' media IDs

  tulir

  committed
  63cef50

  Copy full SHA for 63cef50

Commits on Mar 18, 2022

• Prevent spam by ratelimiting instead of limiting number of IDs

  tulir

  committed
  8ccf85f

  Copy full SHA for 8ccf85f

• Remove streaming requirement

  Show description for 12e907b
  tulir

  committed
  12e907b

  Copy full SHA for 12e907b

• Add unstable prefixes for new error codes

  tulir

  committed
  d582bb3

  Copy full SHA for d582bb3

• Add missing words

  tulir

  committed
  173edf3

  Copy full SHA for 173edf3

Commits on Jul 8, 2022

• Change /create endpoint to use v1

  Show description for f438754
  sumnerevans

  committed
  f438754

  Copy full SHA for f438754

• Reorganize /upload spec and integrate feedback

  Show description for 725675c
  sumnerevans

  committed
  725675c

  Copy full SHA for 725675c

• Rename max_stall_ms -> timeout_ms

  Show description for d55f1f9
  sumnerevans

  committed
  d55f1f9

  Copy full SHA for d55f1f9

• Mention that maximum value for timeout_ms should be imposed by the server

  Show description for 955177b
  sumnerevans

  committed
  955177b

  Copy full SHA for 955177b

• Mention that the timeout_ms can be ignored if the media exists already

  Show description for 823fcca
  sumnerevans

  committed
  823fcca

  Copy full SHA for 823fcca

• Change M_NOT_YET_UPLOADED to use 504 status code

  Show description for 3b00026
  sumnerevans

  committed
  3b00026

  Copy full SHA for 3b00026

• Remove retry_after_ms optional field

  Show description for 9627af2
  sumnerevans

  committed
  9627af2

  Copy full SHA for 9627af2

Commits on Mar 30, 2023

• Make unused_expires_at the deadline for the upload to complete rather than start

  Show description for 045c21e
  sumnerevans

  committed
  045c21e

  Copy full SHA for 045c21e

• Add notes about suggested rate-limiting techniques

  Show description for 011031b
  sumnerevans

  committed
  011031b

  Copy full SHA for 011031b

• Recommend 24 hours instead of 1 minute

  Show description for 6cb7e31
  sumnerevans

  committed
  6cb7e31

  Copy full SHA for 6cb7e31

Commits on Mar 31, 2023

• Merge pull request #3 from beeper/async-uploads-rate-limiting-improvements

  Show description for fedc697
  tulir

  authored
  fedc697

  Copy full SHA for fedc697

Commits on Apr 20, 2023

• Clarify that rate limiting can apply on /create and /upload

  Show description for 7652f59
  sumnerevans

  committed
  7652f59

  Copy full SHA for 7652f59

• Clarify that unused_expires_at is a POSIX millisecond timestamp

  Show description for 098dd90
  sumnerevans

  committed
  098dd90

  Copy full SHA for 098dd90

• Merge pull request #4 from beeper/asynchronous_uploads

  Show description for 9559ab0
  tulir

  authored
  9559ab0

  Copy full SHA for 9559ab0