Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2604: Accept device information for the login fallback endpoint #2604

Merged
merged 1 commit into from
Jun 28, 2020
Merged

MSC2604: Accept device information for the login fallback endpoint #2604

merged 1 commit into from
Jun 28, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Jun 4, 2020 •
edited
Loading

@clokep clokep force-pushed the clokep/login-fallback-device-info branch from 24ce362 to 31f66e8 Compare June 4, 2020 14:19
@clokep clokep mentioned this pull request Jun 4, 2020
Closed
@clokep clokep marked this pull request as ready for review June 4, 2020 14:21
@clokep
Copy link
Member Author

clokep commented Jun 4, 2020 •
edited by richvdh
Loading

matrix-org/synapse#7629 is an implementation for this.

@richvdh richvdh added the proposal A matrix spec change proposal label Jun 4, 2020
@richvdh richvdh self-requested a review June 4, 2020 14:54
@clokep clokep changed the title Accept device information for the login fallback endpoint MSC2604: Accept device information for the login fallback endpoint Jun 4, 2020
@clokep clokep requested a review from a team June 4, 2020 15:06
@clokep clokep mentioned this pull request Jun 4, 2020
Merged
turt2live
turt2live approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fair to me

@turt2live turt2live added kind:maintenance MSC which clarifies/updates existing spec proposal-in-review labels Jun 4, 2020
@richvdh
Copy link
Member

richvdh commented Jun 5, 2020

likewise. we'd like to get this into synapse soon so I'm going to suggest FCP

@richvdh
Copy link
Member

richvdh commented Jun 5, 2020

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jun 5, 2020 •
edited by ara4n
Loading

Team member @richvdh has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jun 5, 2020
@mscbot
Copy link
Collaborator

mscbot commented Jun 23, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jun 23, 2020
@mscbot
Copy link
Collaborator

mscbot commented Jun 28, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jun 28, 2020
@anoadragon453 anoadragon453 merged commit 782aed7 into master Jun 28, 2020
@anoadragon453 anoadragon453 added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jun 28, 2020
@clokep clokep mentioned this pull request Jul 28, 2020
Merged
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review merged A proposal whose PR has merged into the spec! and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jul 28, 2020
@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live mentioned this pull request Oct 14, 2021
Closed
16 tasks
@clokep clokep deleted the clokep/login-fallback-device-info branch May 17, 2023 12:24
@S7evinK S7evinK mentioned this pull request Sep 28, 2023
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clokep @richvdh @mscbot @turt2live @anoadragon453