Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2702: Specifying semantics for Content-Disposition on media #2702

Merged
merged 12 commits into from
Jan 29, 2024

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jul 28, 2020

@turt2live turt2live added proposal-in-review proposal A matrix spec change proposal kind:maintenance MSC which clarifies/updates existing spec labels Jul 28, 2020
@turt2live
Copy link
Member Author

Implementation: t2bot/matrix-media-repo@da0be74

@turt2live turt2live added needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. and removed needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Jun 8, 2021
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Copy link

@davidegirardi davidegirardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review contains 3 comments but 2 of them are old ones. I will try to remove them after submitting this.

proposals/2702-media-content-disposition.md Outdated Show resolved Hide resolved
proposals/2702-media-content-disposition.md Outdated Show resolved Hide resolved
proposals/2702-media-content-disposition.md Outdated Show resolved Hide resolved
@turt2live
Copy link
Member Author

I think this is ready to go as a "nice to have" item for Matrix 1.9/the future:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Sep 8, 2023

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

  • outstanding discussion threads

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Sep 8, 2023
Co-authored-by: David Baker <dbkr@users.noreply.github.com>
@mscbot
Copy link
Collaborator

mscbot commented Jan 28, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jan 28, 2024
@turt2live turt2live dismissed richvdh’s stale review January 29, 2024 17:49

review on older diff

@turt2live turt2live merged commit c6853af into old_master Jan 29, 2024
@turt2live turt2live deleted the travis/msc/media-content-disposition branch January 29, 2024 17:49
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jan 29, 2024
turt2live added a commit that referenced this pull request Jan 29, 2024
* Proposal to introduce sane Content-Disposition semantics

* Update proposals/2702-media-content-disposition.md

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

* Update for the year 2023

* Clarify thumbnails receiving Content-Disposition header

* Clarify layering

* Update proposals/2702-media-content-disposition.md

Co-authored-by: David Baker <dbkr@users.noreply.github.com>

* Fix wording

* Apply suggestions from code review

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* Clarify wording

* Add clarifying words

* Adjust security section

---------

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-authored-by: David Baker <dbkr@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@turt2live turt2live mentioned this pull request Mar 12, 2024
23 tasks
@turt2live
Copy link
Member Author

Spec PR: matrix-org/matrix-spec#1758

@turt2live
Copy link
Member Author

Spec PR: matrix-org/matrix-spec#1935

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Sep 30, 2024
@turt2live
Copy link
Member Author

Merged 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Status: Done to some definition
Status: Scheduled - v1.10
Development

Successfully merging this pull request may close these issues.

10 participants