Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2858: Multiple SSO Identity Providers #2858

Merged
merged 31 commits into from
Mar 14, 2021
Merged
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
2047320
Multiple SSO Identity Providers
t3chguy Nov 9, 2020
a7eba77
Fix MSC number
t3chguy Nov 9, 2020
2064536
Update proposals/2858-Multiple-SSO-Identity-Providers.md
t3chguy Nov 12, 2020
a391a4a
Iterate the MSC
t3chguy Nov 13, 2020
874e32d
Merge remote-tracking branch 'origin/t3chguy/msc/multi-sso' into t3ch…
t3chguy Nov 13, 2020
f444273
be stricter on the icon url
t3chguy Nov 13, 2020
8ac2359
Iterate MSC based on feedback
t3chguy Nov 19, 2020
153c557
Add more explanation
t3chguy Nov 26, 2020
c7063a4
Iterate PR based on feedback
t3chguy Jan 18, 2021
8be6540
Update proposals/2858-Multiple-SSO-Identity-Providers.md
t3chguy Jan 19, 2021
85ccf93
Remove UIA stuff
t3chguy Jan 19, 2021
1d90cac
Merge branch 't3chguy/msc/multi-sso' of github.com:matrix-org/matrix-…
t3chguy Jan 19, 2021
277ff68
Formatting tweaks
richvdh Jan 27, 2021
0c18f83
grammar clarifications
richvdh Jan 27, 2021
09d41c5
add 'brand'
richvdh Jan 27, 2021
8434605
Update proposals/2858-Multiple-SSO-Identity-Providers.md
richvdh Jan 27, 2021
ba08c9f
notes on and alternatives
richvdh Jan 27, 2021
6badb3b
Notes on OAuth2 and unknown idps
richvdh Mar 1, 2021
ba3e204
Update proposals/2858-Multiple-SSO-Identity-Providers.md
t3chguy Mar 1, 2021
dce9c9f
Move the idp `brand` assignments out to a registry
richvdh Mar 2, 2021
434d686
fix up markdown
richvdh Mar 2, 2021
2d4da14
more fix markdown
richvdh Mar 2, 2021
9a4e821
fix link
richvdh Mar 2, 2021
62cc76f
Move sequence diagram into doc
richvdh Mar 3, 2021
a596efd
Get rid of the registry for now
richvdh Mar 3, 2021
178cbe1
Update proposals/2858-Multiple-SSO-Identity-Providers.md
richvdh Mar 3, 2021
1ba0c39
Change the brand identifiers again
richvdh Mar 9, 2021
7871da7
Update proposals/2858-Multiple-SSO-Identity-Providers.md
richvdh Mar 9, 2021
d5166eb
Update proposals/2858-Multiple-SSO-Identity-Providers.md
richvdh Mar 9, 2021
49f7624
update brand descriptions
richvdh Mar 9, 2021
a8a7acc
update UIA
richvdh Mar 9, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
225 changes: 225 additions & 0 deletions proposals/2858-Multiple-SSO-Identity-Providers.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,225 @@
# MSC2858: Multiple SSO Identity Providers

Matrix already has generic SSO support, but it does not yield the best user experience especially for
instances which wish to offer multiple identity providers (IdPs). This MSC provides a simple and fully
backwards compatible way to extend the current spec which would allow clients to give users options
like `Continue with Google` and `Continue with Github` side-by-side.

Currently, Matrix supports `m.login.sso`, `m.login.token` and `/login/sso/redirect` for clients to
pass their user to the configured Identity provider and for them to come back with something which
is exchangeable for a Matrix access token. This flow offers no insight to the user as to what
Identity providers are available: clients can offer only a very generic `Sign in with SSO`
button. With the currently possible solutions and workarounds the experience is far from great
and users have to blindly click `Sign in with SSO` without any clue as to what's hiding on the other
side of the door. Some users will definitely not be familiar with `SSO` but will be with the concept of
"Continue with Google" or similar.

## Proposal

We extend the [login
flow](https://matrix.org/docs/spec/client_server/r0.6.1#login) to allow clients
to choose an SSO Identity provider before control is handed over to the
server. The following sequence diagram illustrates the proposed, updated, login flow:

<!-- source for the following is in images/2858-seq-diagram.txt -->

![Sequence diagram](https://user-images.githubusercontent.com/2403652/104897523-61fb4b00-5970-11eb-88f7-9fc0956b33a2.png)

### Extensions to login flow discovery

The response to [`GET /_matrix/client/r0/login`](https://matrix.org/docs/spec/client_server/r0.6.1#get-matrix-client-r0-login)
is extended to **optionally** include an `identity_providers` property for
flows whose type `m.login.sso`. This would look like this:

```json
{
"flows": [
{
"type": "m.login.sso",
"identity_providers": [
{
"id": "google",
t3chguy marked this conversation as resolved.
Show resolved Hide resolved
"name": "Google",
"icon": "mxc://...",
"brand": "org.matrix.google"
},
{
"id": "github",
"name": "Github",
"icon": "mxc://...",
"brand": "org.matrix.github"
}
]
},
{
"type": "m.login.token"
}
]
}
```

The value of the `identity_providers` property is a list, each entry consisting
of an object with the following fields:

* The `id` field is **required**. It is an opaque string chosen by the
homeserver implementation, and uniquely identifies the identity provider on
that server. Clients should not infer any semantic meaning from the
identifier. The identifier should be between 1 and 255 characters in length,
and should consist of the characters matching unreserved URI characters as
defined in [RFC3986](http://www.ietf.org/rfc/rfc3986.txt):

```
ALPHA DIGIT "-" / "." / "_" / "~"
```

* The `name` field is **required**. It should be a human readable string
intended for printing by the client. No explicit length limit or grammar is
specified.

* The `icon` field is **optional**. It should point to an icon representing
the IdP. If present then it must be an MXC URI to an image resource.

* The `brand` field is **optional**. It allows the client to style the login
button to suit a particular brand. It should be a string matching the
"Common namespaced identifier grammar" as defined in
[MSC2758](https://github.com/matrix-org/matrix-doc/pull/2758).

To reduce confusion over which indentifier should be used for each brand
richvdh marked this conversation as resolved.
Show resolved Hide resolved
(for example: should "Sign in with Microsoft" be `com.microsoft` or
`com.azure`?), it is proposed to maintain a registry of identifiers outside
the core specification document, avoiding the need for a full MSC to add
entries to the list. An initial list of proposed identifiers is given below.

Server implementations are free to add additional brands, though they should
be mindful of clients which do not recognise any given brand.

Clients are free to implement any set of brands they wish, including all or
any of the brands listed in the registry, but are expected to apply a
sensible unbranded fallback for any brand they do not recognise/support.

Where `icon` and `brand` are both present, it is recommended that clients
which support the `brand` give precedence to `brand` over `icon`.

### Extend the `/login/sso/redirect` endpoint

A new endpoint is added to support redirecting directly to one of the IdPs:

`GET /_matrix/client/r0/login/sso/redirect/{idp_id}`

This would behave identically to the existing endpoint without the last argument
except would allow the server to forward the user directly to the correct IdP.

For the case of backwards compatibility the existing endpoint is to remain,
and if the server supports multiple SSO IdPs it should offer the user a page
which lets them choose between the available IdP options as a fallback.

If the `idp_id` is unrecognised, the server should display some sort of error
page to the user. (A protocol whereby an error can be returned to the original
client could be a matter for a future improvement, but is out of scope for now.)

### Notes on user-interactive auth

For the case of User Interactive Auth the server would just give the standard
SSO flow option without any `identity_providers` as there is no method for
a client to choose an IdP within that flow at this time nor is it as
essential.
richvdh marked this conversation as resolved.
Show resolved Hide resolved

### Proposed initial identifiers for the `brand` indentifier

* Identifier: `com.apple`

Description: "Sign in with Apple". See
richvdh marked this conversation as resolved.
Show resolved Hide resolved
https://developer.apple.com/design/human-interface-guidelines/sign-in-with-apple/overview/buttons/.

* Identifier: `com.facebook`

Description: "Continue with Facebook". See
https://developers.facebook.com/docs/facebook-login/web/login-button/.

* Identifier: `com.github`

Description: Logos available at https://github.com/logos.
richvdh marked this conversation as resolved.
Show resolved Hide resolved

* Identifier: `com.gitlab`

Description: Login in via the hosted https://gitlab.com SaaS platform.
richvdh marked this conversation as resolved.
Show resolved Hide resolved

* Identifier: `com.google`

Description: "Sign in with Google". See
https://developers.google.com/identity/branding-guidelines.

* Identifier: `com.twitter`

Description: "Log in with Twitter". See
https://developer.twitter.com/en/docs/authentication/guides/log-in-with-twitter#tab1.

## Alternatives
t3chguy marked this conversation as resolved.
Show resolved Hide resolved
richvdh marked this conversation as resolved.
Show resolved Hide resolved

An alternative to the whole approach would be to allow `m.login.sso.$idp` but this forces
treating an opaque identifier as hierarchical and offers worse backwards compatibility.

An alternative to the proposed backwards compatibility plan where the server offers a
fallback page which fills the gap and lets the user choose which SSO IdP they need is
for the server to deterministically always pick one, maybe the first option and let
old clients only auth via that one but that means potentially locking users out of their
accounts.

[MSC2964](https://github.com/matrix-org/matrix-doc/pull/2964) proposes
replacing much of Matrix's authentication mechanism with OAuth2.0. If that is
adopted, then the Matrix client would not be able to specify an authentication
mechanism; rather it is left up to the server to host pages allowing the user
to choose their authentication mechanism.

### Styling information as an alternative to `brand`

The `brand` field is intended to allow clients to style "login" buttons according
to the identity provider in question. For example, a mobile application might
show:

![login buttons](images/2858-login.png)

Some identity providers have very specific rules about how such buttons should
be presented, so a fine level of control is important.

An alternative way to achieve this would be for the server to give full details
about the styling: icon, font colour, border colour, background colour,
etc. However, this soon becomes unscalable. For example, it might be desirable
to offer each logo at a range of resolutions to suit different screen sizes.
Likewise, some brands need different styling depending on the background
colour, so a complete second set of colours must be specified to account for
dark or light themes.

## Potential issues

* New Identity Providers added by server administators will be unbranded until
clients adopt support for the new brand.

## Security considerations

This could potentially aid phishing attacks by bad homeservers, where if the app says
`Continue with Google` and then they are taken to a page which is styled to look like
the Google login page they might be a tiny bit more susceptible to being phished as opposed
as to when they click a more generic `Sign in with SSO` button, but this attack was possible
anyhow using a different vector of a controlled Element/client instance which modifies
the text.


## Unstable prefix

Whilst in development use `org.matrix.msc2858.identity_providers` for the flow
discovery and
`/_matrix/client/unstable/org.matrix.msc2858/login/sso/redirect/{idp_id}` for
the new endpoints.

When identity providers are listed under the experimental
`org.matrix.msc2858.identity_providers` field of the response to `/login`,
(instead of `identity_providers`), different values for the `brand` field are
used. In particular the following were defined:

* `org.matrix.gitlab` (now `com.gitlab`).
* `org.matrix.github` (now `com.github`).
* `org.matrix.apple` (now `com.apple`).
* `org.matrix.google` (now `com.google`).
* `org.matrix.facebook` (now `com.facebook`).
* `org.matrix.twitter` (now `com.twitter`).
Binary file added proposals/images/2858-login.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.