Remove aliases from /publicRooms response
#3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
commented
Jan 5, 2022
| @@ -0,0 +1 @@ | |||
| The `aliases` property from the chunks returned by `/publicRooms`, as per [MSC2432](https://github.com/matrix-org/matrix-doc/pull/2432). | |||
There was a problem hiding this comment.
I've listed this as breaking because while it doesn't appear to affect anyone, it is a removal without deprecation.
This was referenced Jan 5, 2022
Merged
turt2live
added a commit
to matrix-org/synapse
that referenced
this pull request
Jan 5, 2022
turt2live
force-pushed
the
travis/spec/spaces-1-1772-3288-2946
branch
from
51bbc2e
to
e68dc2f
Compare
turt2live
force-pushed
the
travis/remove-aliases-publicrooms
branch
from
8d15952
to
a7e7e92
Compare
richvdh
force-pushed
the
travis/spec/spaces-1-1772-3288-2946
branch
from
6616a5e
to
493f730
Compare
richvdh
force-pushed
the
travis/remove-aliases-publicrooms
branch
from
a7e7e92
to
4a67c58
Compare
turt2live
changed the base branch from
travis/spec/spaces-1-1772-3288-2946
to
main
Through attempting to land [Synapse#11667](matrix-org/synapse#11667) it was found that Synapse doesn't return the `aliases` property on `/publicRooms` as it was [removed](matrix-org/synapse#6970) by a [tracking issue](matrix-org/synapse#6898) referencing [MSC2432](#2432) as its base. Though MSC2432 does not make mention of this, the [document](https://docs.google.com/document/d/1NNDkobiFLeUkJtyj0H6qvKIedgvIkZnFKo78-03cGEk/edit) the MSC is based upon makes deliberate effort to mention the endpoint and the removal of `aliases`. Thus, it is determined as a likely accidental omission from the formal MSC and therefore the formal spec. This has been corrected here by amending the MSC (per the process) and removing the field, basing itself off of the [spec PR for spaces](#3610) for diff clarity.
turt2live
force-pushed
the
travis/remove-aliases-publicrooms
branch
from
4a67c58
to
e5509f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is pointing at the Spaces branch to have a readable diff. This will be changed tomainprior to merging, which is dependent on #3610Fixes #3056
Through attempting to land Synapse#11667 it was found that Synapse doesn't return the
aliasesproperty on/publicRoomsas it was removed by a tracking issue referencing MSC2432 as its base. Though MSC2432 does not make mention of this, the document the MSC is based upon makes deliberate effort to mention the endpoint and the removal ofaliases. Thus, it is determined as a likely accidental omission from the formal MSC and therefore the formal spec.This has been corrected here by amending the MSC (per the process) and removing the field, basing itself off of the spec PR for spaces for diff clarity.
Preview: https://pr3624--matrix-org-previews.netlify.app