Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC3773: Notifications for threads #3773
MSC3773: Notifications for threads #3773
Changes from 6 commits
720ff50
5ca370a
941b65d
b4755fc
8edb4ec
c88d910
94bf9ac
d0b6bef
361d3b0
3c69f2b
3f2d435
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To help with this, could a homeserver choose to omit the
unread_thread_notifications
field altogether if the unread counts have not changed since the previous/sync
response?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean omit the entire field or the individual threads in it? If the latter, I think that would be quite hard to do, but might be doable! The former seems likely doable, but I don't love making it act differently than
unread_notifications
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The former, omitting the field when a new event has appeared in the main timeline (and thus would not update unread thread counts. Especially since many rooms won't have threads in them.
I agree, and we could change always make this change later of course. I also wouldn't mind making the same change to
unread_notifications
in the future.