Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC4126: Deprecation of query string auth #4126

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Apr 10, 2024

Rendered

In line with matrix-org/matrix-spec#1700, the following disclosure applies:

I am Director of Standards Development at The Matrix.org Foundation C.I.C., Matrix Spec Core Team (SCT) member, employed by Element, and operate the t2bot.io service. This proposal is written and published with my role as a member of the SCT.

Fixes matrix-org/matrix-spec#1780

FCP tickyboxes

@turt2live turt2live changed the title MSC: Deprecation of query string auth MSC4126: Deprecation of query string auth Apr 10, 2024
@turt2live turt2live marked this pull request as ready for review April 10, 2024 21:48
@turt2live turt2live added proposal A matrix spec change proposal identity service client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec labels Apr 10, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation requirements:

  • None, in my opinion. The MSC is not feasible to implement beyond what has already been described in the proposal itself.

@tulir
Copy link
Member

tulir commented Apr 10, 2024

Looks good, I see no reason to delay this

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Apr 10, 2024

Team member @tulir has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Apr 10, 2024
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@mscbot
Copy link
Collaborator

mscbot commented Apr 17, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Apr 17, 2024
@mscbot
Copy link
Collaborator

mscbot commented Apr 22, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Apr 22, 2024
@turt2live turt2live merged commit 72e694b into main Apr 22, 2024
1 check passed
@turt2live turt2live deleted the travis/msc/deprecate-qs-auth branch April 22, 2024 15:26
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Apr 22, 2024
@richvdh
Copy link
Member

richvdh commented Apr 30, 2024

Spec PR: matrix-org/matrix-spec#1808

@richvdh
Copy link
Member

richvdh commented Apr 30, 2024

Merged to the spec! 🎉

@richvdh richvdh added merged A proposal whose PR has merged into the spec! and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Apr 30, 2024
@zecakeh zecakeh mentioned this pull request Jun 7, 2024
53 tasks
@mscbot mscbot added the final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. label Sep 23, 2024
@matrix-org matrix-org deleted a comment from mscbot Sep 23, 2024
@anoadragon453 anoadragon453 removed the final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API identity service kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Status: Done to some definition
Development

Successfully merging this pull request may close these issues.

Passing access tokens as query parameters should be deprecated
5 participants