Spec /relations and aggregations
#1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
reviewed
May 16, 2022
Apparently this breaks the table of contents
clokep
reviewed
May 18, 2022
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
|
@clokep github isn't letting me re-request review from you for some reason, but if you get a chance then a second look would be appreciated (non-blocking, though). |
This was referenced May 27, 2022
clokep
reviewed
May 27, 2022
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
|
@richvdh this should be ready for re-review, with the commits since your last review being reviewable individually (largely). |
richvdh
requested changes
Jun 8, 2022
richvdh
reviewed
Jun 8, 2022
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
richvdh
reviewed
Jun 8, 2022
This was referenced Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Originally this branch was intended to also carry MSC3440 (MD; Threads), however it was determined that in order to include threads we'll need a bit more of the feature to land first. There shouldn't be any lingering references to threads (at least in a "threads are specced" capacity) - please point them out if they are still there.
Reviewer: The diff is a bit messy and the commit history isn't much better, sorry. To summarize what has happened: the rich replies stuff got broken out to a dedicated module (in preparation for Threads getting a dedicated module itself) and the relationships stuff got airlifted to a higher part of the spec. Then, edits to all the sections to make the text clear/match the MSCs.
Preview: https://pr1062--matrix-spec-previews.netlify.app