-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify parameter definition for third-party location lookups #1947
Clarify parameter definition for third-party location lookups #1947
Conversation
…meters While 1405184 redefined most fields to be the appropriate object type, it missed one of them. Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
Sorry for the delay in reviewing this. It took me a while to figure out what is going on here; but with reference to a previous discussion thread and the OpenAPI spec, I think I've figured it out. I'll write down my conclusions for the sake of future archaeologists (including myself). As I understand it, this is replacing the The relevant part of the OpenAPI spec is the definition of the Parameter Object; in particular the rules for serialization of the parameter. The relevant OpenAPI fields are [I now see that @deepbluev7 has reached much the same conclusion at https://github.com//issues/560#issuecomment-2344138695.] It's worth noting that the name of the object parameter ( Looking at #560, and #1584, this appears to be a correct change. |
I've opened #1993 to track the fact that the spec text makes a mess of this. |
While 1405184 redefined most fields to be the appropriate object type, it missed one of them.
Signed-off-by: Nicolas Werner nicolas.werner@hotmail.de
Pull Request Checklist
Preview: https://pr1947--matrix-spec-previews.netlify.app