Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema of custom fields in query for appservice API #1584

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Fix schema of custom fields in query for appservice API #1584

merged 3 commits into from
Jul 5, 2023

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Jun 22, 2023 •
edited by github-actions bot
Loading

@zecakeh
Fix schema of custom fields in query for appservice API
2cc1017 
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner June 22, 2023 12:48
@zecakeh
Add changelog
a67f411 
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
KitsuneRal
KitsuneRal reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ellipses from the parameter name can also be dropped now, unless something else relies on them (I really hope not)

@zecakeh
Remove ellipses
6b2450d 
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@turt2live turt2live requested a review from KitsuneRal July 5, 2023 07:03
@zecakeh
Copy link
Contributor Author

zecakeh commented Jul 5, 2023

I removed the ellipses, I don't think anything relied on them.

KitsuneRal
KitsuneRal approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@KitsuneRal KitsuneRal merged commit 1405184 into matrix-org:main Jul 5, 2023
@zecakeh zecakeh deleted the fix-query-fields branch July 5, 2023 16:21
@zecakeh zecakeh mentioned this pull request Aug 21, 2023
Closed
28 tasks
@richvdh richvdh mentioned this pull request Nov 12, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zecakeh @KitsuneRal