Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to define a valid event #1045

Merged
merged 3 commits into from
May 10, 2022
Merged

Attempt to define a valid event #1045

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c5e991
Attempt to define a valid event
May 4, 2022
f477e9e
Changelog
May 4, 2022
3fb806d
link to /rooms, thanks Travis
DMRobertson May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/server_server/newsfragments/1045.clarification
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Expand a little on what it means for a PDU to be valid when discussing checks on PDUs.
4 changes: 3 additions & 1 deletion content/server-server-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,9 @@ specification](/rooms).
Whenever a server receives an event from a remote server, the receiving
server must ensure that the event:

1. Is a valid event, otherwise it is dropped.
1. Is a valid event, otherwise it is dropped. For an event to be valid, it
must contain a `room_id`, and it must comply with the event format of
that room version.
DMRobertson marked this conversation as resolved.
Show resolved Hide resolved
2. Passes signature checks, otherwise it is dropped.
3. Passes hash checks, otherwise it is redacted before being processed
further.
Expand Down